add v8.5.5 release notes (#22190) #22332
Conversation
Signed-off-by: Ben Meadowcroft <[email protected]>
Co-authored-by: Grace Cai <[email protected]>
Co-authored-by: okJiang <[email protected]>
Co-authored-by: hongyunyan <[email protected]>
Co-authored-by: Ruihao Chen <[email protected]>
Co-authored-by: 山岚 <[email protected]>
Co-authored-by: Bisheng Huang <[email protected]>
Co-authored-by: Aolin <[email protected]>
Co-authored-by: Aolin <[email protected]>
Co-authored-by: Aolin <[email protected]>
ti-chi-bot
added
lgtm
size/XL
Summary of ChangesHello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the comprehensive release notes for TiDB version 8.5.5. It documents a wide array of enhancements, including substantial performance optimizations for DDL operations and query execution, critical improvements in backup and restore capabilities, and increased system reliability and availability. The release also brings new observability features, enhanced security, and numerous bug fixes across all core components and tools, ensuring a more robust and efficient database experience. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the release notes for TiDB v8.5.5. The documentation is well-written and comprehensive. I've provided a few minor suggestions to improve clarity, readability, and consistency with the style guide. My feedback includes recommendations to use the second person ("you") when addressing the user, breaking up long sentences, and ensuring consistent spelling. Overall, great work on documenting the new release.
|
|
||
| - **Improved recovery performance**: SST files can be more quickly imported into the cluster. | ||
| - **Reduced storage space consumption**: redundant data is removed during compaction. | ||
| - **Reduced impact on applications**: RPOs (Recovery Point Objective) can be maintained with less frequent full snapshot-based backups. |
There was a problem hiding this comment.
To improve clarity and follow the style guide's recommendation to use the second person, consider rephrasing this point.
| - **Reduced impact on applications**: RPOs (Recovery Point Objective) can be maintained with less frequent full snapshot-based backups. | |
| - **Reduced impact on applications**: You can maintain your Recovery Point Objectives (RPOs) with less frequent full snapshot-based backups. |
References
- Write in second person ("you") when addressing users. (link)
|
|
||
| * Improve scheduling stability in TiKV during network jitter [#9359](https://github.com/tikv/pd/issues/9359) @[okJiang](https://github.com/okJiang) | ||
|
|
||
| Starting from v8.5.5, TiKV introduces a network slow-node detection and feedback mechanism. When this mechanism is enabled, TiKV probes network latency between nodes, calculates a network slow score, and reports the score to PD. Based on this score, PD evaluates the network status of TiKV nodes and adjusts scheduling accordingly: when a TiKV node is detected to be experiencing network jitter, PD restricts the scheduling of new Leaders to that node; if the network jitter persists, PD proactively evicts existing Leaders from the affected node to other TiKV nodes, thereby reducing the impact of network issues on the cluster. |
There was a problem hiding this comment.
This sentence is quite long and complex. For better readability, I suggest breaking it into smaller sentences.
| Starting from v8.5.5, TiKV introduces a network slow-node detection and feedback mechanism. When this mechanism is enabled, TiKV probes network latency between nodes, calculates a network slow score, and reports the score to PD. Based on this score, PD evaluates the network status of TiKV nodes and adjusts scheduling accordingly: when a TiKV node is detected to be experiencing network jitter, PD restricts the scheduling of new Leaders to that node; if the network jitter persists, PD proactively evicts existing Leaders from the affected node to other TiKV nodes, thereby reducing the impact of network issues on the cluster. | |
| Starting from v8.5.5, TiKV introduces a network slow-node detection and feedback mechanism. When this mechanism is enabled, TiKV probes network latency between nodes, calculates a network slow score, and reports the score to PD. Based on this score, PD evaluates the network status of TiKV nodes and adjusts scheduling accordingly. For example, when a TiKV node is detected to be experiencing network jitter, PD restricts the scheduling of new Leaders to that node. If the network jitter persists, PD proactively evicts existing Leaders from the affected node to other TiKV nodes, thereby reducing the impact of network issues on the cluster. |
References
- Make sure the documentation is easy to understand for TiDB users. (link)
|
|
||
| * Add storage engine identifiers to statement summary tables and slow query logs [#61736](https://github.com/pingcap/tidb/issues/61736) @[henrybw](https://github.com/henrybw) | ||
|
|
||
| When both TiKV and TiFlash are deployed in a cluster, users often need to filter SQL statements by storage engine during database diagnostics and performance optimization. For example, if TiFlash is under high load, users might need to identify SQL statements running on TiFlash to locate potential causes. To meet this need, starting from v8.5.5, TiDB adds storage engine identifier fields to statement summary tables and slow query logs. |
There was a problem hiding this comment.
The style guide recommends addressing the user directly with "you" instead of "users".
| When both TiKV and TiFlash are deployed in a cluster, users often need to filter SQL statements by storage engine during database diagnostics and performance optimization. For example, if TiFlash is under high load, users might need to identify SQL statements running on TiFlash to locate potential causes. To meet this need, starting from v8.5.5, TiDB adds storage engine identifier fields to statement summary tables and slow query logs. | |
| When both TiKV and TiFlash are deployed in a cluster, you often need to filter SQL statements by storage engine during database diagnostics and performance optimization. For example, if TiFlash is under high load, you might need to identify SQL statements running on TiFlash to locate potential causes. To meet this need, starting from v8.5.5, TiDB adds storage engine identifier fields to statement summary tables and slow query logs. |
References
- Write in second person ("you") when addressing users. (link)
|
|
||
| ### Behavior changes | ||
|
|
||
| * Starting from v8.5.5, TiDB automatically sets target tables to `restore` mode during data restore. Tables in `restore` mode prohibit any user read or write operations. Once the restore completes, TiDB automatically switches the mode back to `normal` for these tables, allowing users to read and write the tables normally. This behavior ensures task stability and data consistency during the restore process. |
There was a problem hiding this comment.
To improve clarity and align with the style guide's preference for the second person, I suggest a small wording change.
| * Starting from v8.5.5, TiDB automatically sets target tables to `restore` mode during data restore. Tables in `restore` mode prohibit any user read or write operations. Once the restore completes, TiDB automatically switches the mode back to `normal` for these tables, allowing users to read and write the tables normally. This behavior ensures task stability and data consistency during the restore process. | |
| * Starting from v8.5.5, TiDB automatically sets target tables to `restore` mode during data restore. Tables in `restore` mode prohibit any read or write operations. Once the restore completes, TiDB automatically switches the mode back to `normal` for these tables, allowing you to read and write the tables normally. This behavior ensures task stability and data consistency during the restore process. |
References
- Write in second person ("you") when addressing users. (link)
|
|
||
| + TiDB | ||
|
|
||
| - Improve error messages for `IMPORT INTO` when encoding errors occur to help users identify issues more accurately [#63763](https://github.com/pingcap/tidb/issues/63763) @[D3Hunter](https://github.com/D3Hunter) |
There was a problem hiding this comment.
The style guide recommends addressing the user directly with "you" instead of "users".
| - Improve error messages for `IMPORT INTO` when encoding errors occur to help users identify issues more accurately [#63763](https://github.com/pingcap/tidb/issues/63763) @[D3Hunter](https://github.com/D3Hunter) | |
| - Improve error messages for `IMPORT INTO` when encoding errors occur to help you identify issues more accurately [#63763](https://github.com/pingcap/tidb/issues/63763) @[D3Hunter](https://github.com/D3Hunter) |
References
- Write in second person ("you") when addressing users. (link)
|
|
||
| + TiDB | ||
|
|
||
| - Fix the issue that TiDB fails to read the latest value of the `tidb_mem_quota_binding_cache` variable to perform initialization binding during startup [#65381](https://github.com/pingcap/tidb/issues/65381) @[qw4990](https://github.com/qw4990) |
There was a problem hiding this comment.
For better readability, consider rephrasing "Fix the issue that" to "Fix an issue where". This suggestion can be applied to other items in the "Bug fixes" section as well.
| - Fix the issue that TiDB fails to read the latest value of the `tidb_mem_quota_binding_cache` variable to perform initialization binding during startup [#65381](https://github.com/pingcap/tidb/issues/65381) @[qw4990](https://github.com/qw4990) | |
| - Fix an issue where TiDB fails to read the latest value of the `tidb_mem_quota_binding_cache` variable to perform initialization binding during startup [#65381](https://github.com/pingcap/tidb/issues/65381) @[qw4990](https://github.com/qw4990) |
References
- Clarity, simplicity, completeness, and readability (link)
| - Fix the issue that admin check does not report errors when index records are missing [#63698](https://github.com/pingcap/tidb/issues/63698) @[wjhuang2016](https://github.com/wjhuang2016) | ||
| - Fix the issue that modifying the collation via `MODIFY COLUMN` results in data index inconsistency [#61668](https://github.com/pingcap/tidb/issues/61668) @[tangenta](https://github.com/tangenta) | ||
| - Fix the issue that the embedded `ANALYZE` feature in DDL might not be triggered when performing multiple schema changes [#65040](https://github.com/pingcap/tidb/issues/65040) @[joechenrh](https://github.com/joechenrh) | ||
| - Fix the issue that the Distributed eXecution Framework (DXF) task is not cancelled after canceling the `ADD INDEX` job [#64129](https://github.com/pingcap/tidb/issues/64129) @[tangenta](https://github.com/tangenta) |
There was a problem hiding this comment.
To maintain consistent spelling throughout the document, "cancelled" should be changed to "canceled". Other parts of the document use "canceled" (e.g., line 280).
| - Fix the issue that the Distributed eXecution Framework (DXF) task is not cancelled after canceling the `ADD INDEX` job [#64129](https://github.com/pingcap/tidb/issues/64129) @[tangenta](https://github.com/tangenta) | |
| - Fix the issue that the Distributed eXecution Framework (DXF) task is not canceled after canceling the `ADD INDEX` job [#64129](https://github.com/pingcap/tidb/issues/64129) @[tangenta](https://github.com/tangenta) |
References
- Correct English grammar, spelling, and punctuation mistakes, if any. (link)
| - Fix the issue that a large number of Leader transfers might cause sudden changes in Region size [#10014](https://github.com/tikv/pd/issues/10014) @[lhy1024](https://github.com/lhy1024) | ||
| - Fix the issue that might cause PD panic during scheduling [#9951](https://github.com/tikv/pd/issues/9951) @[bufferflies](https://github.com/bufferflies) | ||
| - Fix the issue that data might become imbalanced during the import process [#9088](https://github.com/tikv/pd/issues/9088) @[GMHDBJD](https://github.com/GMHDBJD) | ||
| - Fix the issue that, after enabling the Active PD Follower feature, requests that fail on a Follower node cannot correctly fall back to the Leader node for retry [#64933](https://github.com/pingcap/tidb/issues/64933) @[okJiang](https://github.com/okJiang) |
There was a problem hiding this comment.
The style guide recommends addressing the user directly with "you".
| - Fix the issue that, after enabling the Active PD Follower feature, requests that fail on a Follower node cannot correctly fall back to the Leader node for retry [#64933](https://github.com/pingcap/tidb/issues/64933) @[okJiang](https://github.com/okJiang) | |
| - Fix the issue that, after you enable the Active PD Follower feature, requests that fail on a Follower node cannot correctly fall back to the Leader node for retry [#64933](https://github.com/pingcap/tidb/issues/64933) @[okJiang](https://github.com/okJiang) |
References
- Write in second person ('you') when addressing users. (link)
|
/approve |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6 participants
This is an automated cherry-pick of #22190
What is changed, added or deleted? (Required)
As in the title, this PR adds the release note doc for v8.5.5.
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?